rdblue commented on code in PR #6139: URL: https://github.com/apache/iceberg/pull/6139#discussion_r1024484533
########## python/pyiceberg/expressions/__init__.py: ########## @@ -18,18 +18,37 @@ from __future__ import annotations from abc import ABC, abstractmethod -from dataclasses import dataclass from functools import reduce -from typing import ClassVar, Generic, TypeVar - -from pyiceberg.expressions.literals import Literal +from typing import ( + Any, + Generic, + Iterable, + Set, + Type, + Union, +) + +from pyiceberg.expressions.literals import Literal, literal from pyiceberg.files import StructProtocol from pyiceberg.schema import Accessor, Schema +from pyiceberg.typedef import L Review Comment: Renaming the generic `T` to `L` requires a ton of changes and I'm not sure that it is worth doing. The only benefit is that we are getting a type bound on `T`, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
