rdblue commented on code in PR #6139: URL: https://github.com/apache/iceberg/pull/6139#discussion_r1027143589
########## python/pyiceberg/expressions/literals.py: ########## @@ -82,15 +76,15 @@ def to(self, type_var: IcebergType) -> Literal: ... # pragma: no cover def __repr__(self) -> str: - return f"{type(self).__name__}({self.value})" + return f"{type(self).__name__}({self.value!r})" Review Comment: In most places we use `repr(self.value)` rather than `!r`. Is there a best practice to choose between the two? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org