manuzhang commented on code in PR #13381: URL: https://github.com/apache/iceberg/pull/13381#discussion_r2166222173
########## spark/v3.5/build.gradle: ########## @@ -20,6 +20,14 @@ String sparkMajorVersion = '3.5' String scalaVersion = System.getProperty("scalaVersion") != null ? System.getProperty("scalaVersion") : System.getProperty("defaultScalaVersion") +def currentJavaVersion = JavaVersion.current() + +if (!(currentJavaVersion.is(JavaVersion.VERSION_11) || currentJavaVersion.is(JavaVersion.VERSION_17) Review Comment: Spark 3.5 build with all supported JDKs so no check is needed here. ########## spark/v3.5/build.gradle: ########## @@ -20,6 +20,14 @@ String sparkMajorVersion = '3.5' String scalaVersion = System.getProperty("scalaVersion") != null ? System.getProperty("scalaVersion") : System.getProperty("defaultScalaVersion") +def currentJavaVersion = JavaVersion.current() + +if (!(currentJavaVersion.is(JavaVersion.VERSION_11) || currentJavaVersion.is(JavaVersion.VERSION_17) Review Comment: Spark 3.5 builds with all supported JDKs so no check is needed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org