zhztheplayer commented on code in PR #13381:
URL: https://github.com/apache/iceberg/pull/13381#discussion_r2166215229


##########
spark/v4.0/build.gradle:
##########
@@ -20,6 +20,11 @@
 String sparkMajorVersion = '4.0'
 String scalaVersion = '2.13'
 
+if (!JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_17)) {

Review Comment:
   Ahh, got it. 
   
   Since we have this 11 / 17 / 21 
[check](https://github.com/apache/iceberg/blob/522de0fe839df2f22f4472241bce632995adc01d/build.gradle#L54-L82)
 in the root script, would you mean we should add own checks for each Spark 
module?
   
   I'll update the PR for all Spark versions if I don't misunderstood something 
here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to