nastra commented on code in PR #13381:
URL: https://github.com/apache/iceberg/pull/13381#discussion_r2166379947
##########
spark/v4.0/build.gradle:
##########
@@ -20,6 +20,13 @@
String sparkMajorVersion = '4.0'
String scalaVersion = '2.13'
+def currentJavaVersion = JavaVersion.current()
+
+if (!(currentJavaVersion.is(JavaVersion.VERSION_17) ||
currentJavaVersion.is(JavaVersion.VERSION_21))) {
Review Comment:
to be more in line with other places in the code, could you please update
this to
```
JavaVersion javaVersion = JavaVersion.current()
if (javaVersion != JavaVersion.VERSION_17 && javaVersion !=
JavaVersion.VERSION_21) {
throw new GradleException("Spark 4.0 build requires JDK 17 or 21 but was
executed with JDK " + javaVersion)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
