zhztheplayer commented on code in PR #13381: URL: https://github.com/apache/iceberg/pull/13381#discussion_r2166182135
########## spark/v4.0/build.gradle: ########## @@ -20,6 +20,11 @@ String sparkMajorVersion = '4.0' String scalaVersion = '2.13' +if (!JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_17)) { Review Comment: But that will make Iceberg + Spark 4.0 require at least JDK 21 to build ? For example I can build them with JDK 17 without failures but after that change, I have to switch to JDK 21. Am I missing something here? This is the Spark's JDK requirement which is 17 for 4.0: https://github.com/apache/spark/blob/fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4/pom.xml#L117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org