zhztheplayer commented on code in PR #13381:
URL: https://github.com/apache/iceberg/pull/13381#discussion_r2166276472
##########
spark/v4.0/build.gradle:
##########
@@ -20,6 +20,11 @@
String sparkMajorVersion = '4.0'
String scalaVersion = '2.13'
+if (!JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_17)) {
Review Comment:
@Fokko Yes I understand this point. I was thinking we already had a 11 / 17
/ 21 check in the root script so just we could just add check for `version >
17` which would cover both 17 and 21.
##########
spark/v4.0/build.gradle:
##########
@@ -20,6 +20,11 @@
String sparkMajorVersion = '4.0'
String scalaVersion = '2.13'
+if (!JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_17)) {
Review Comment:
@Fokko Yes I understand this point. I was thinking we already had a 11 / 17
/ 21 check in the root script so just we could just add check for `version >
17` which would inherently cover both 17 and 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
