zhztheplayer commented on code in PR #13381:
URL: https://github.com/apache/iceberg/pull/13381#discussion_r2166235479
##########
spark/v3.5/build.gradle:
##########
@@ -20,6 +20,14 @@
String sparkMajorVersion = '3.5'
String scalaVersion = System.getProperty("scalaVersion") != null ?
System.getProperty("scalaVersion") : System.getProperty("defaultScalaVersion")
+def currentJavaVersion = JavaVersion.current()
+
+if (!(currentJavaVersion.is(JavaVersion.VERSION_11) ||
currentJavaVersion.is(JavaVersion.VERSION_17)
Review Comment:
Just curious, if [the root
check](https://github.com/apache/iceberg/blob/522de0fe839df2f22f4472241bce632995adc01d/build.gradle#L54-L82)
can be leveraged, any specific reason we need to check
`currentJavaVersion.is(JavaVersion.VERSION_21)` for 4.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
