RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2049681573


##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java:
##########
@@ -887,11 +887,14 @@ public static void asMetadataRecord(GenericData.Record 
file) {
     file.put(3, 0); // specId
   }
 
+  // suppress the readable metrics and first-row-id that are not in manifest 
files

Review Comment:
   I have no idea what our standard on this is really
   
   // [A-Z]
   Has 5422 Hits
   
   // [a-z]
   Has 10896 Hits
   
   So we definitely are leaning towards no case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to