wypoon commented on code in PR #12681:
URL: https://github.com/apache/iceberg/pull/12681#discussion_r2032163482
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/CachedClientPool.java:
##########
@@ -132,7 +131,7 @@ public <R> R run(Action<R, IMetaStoreClient, TException>
action, boolean retry)
static Key extractKey(String cacheKeys, Configuration conf) {
// generate key elements in a certain order, so that the Key instances are
comparable
List<Object> elements = Lists.newArrayList();
- elements.add(conf.get(HiveConf.ConfVars.METASTOREURIS.varname, ""));
+ elements.add(conf.get("hive.metastore.uris", ""));
Review Comment:
I think it is not necessary and I don't see the benefit. Spark had to deal
with this issue too, and they used the conf name or
`HiveConf.getConfVars("...")` with the conf name if they needed a enum
instance. They didn't go so far as to define a collection of constants for the
conf names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
