manuzhang commented on code in PR #12681: URL: https://github.com/apache/iceberg/pull/12681#discussion_r2030391071
########## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java: ########## @@ -303,10 +303,10 @@ public void testThriftExceptionConcurrentCommit() throws TException, Interrupted @Test public void testInvalidObjectException() { - TableIdentifier badTi = TableIdentifier.of(DB_NAME, "`tbl`"); + TableIdentifier badTi = TableIdentifier.of(DB_NAME, "tábl"); Review Comment: Do we need to test changes before and after hive4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org