wypoon commented on PR #12681: URL: https://github.com/apache/iceberg/pull/12681#issuecomment-2784870391
@manuzhang thanks for reviewing! I'd prefer not to follow the approach taken by Spark and Flink, to have versioned directories with duplicated code. I'm trying to keep a single version of code all in one directory as far as possible. The model is more the old mr and hive3 directories. If you mean keep versioned directories under hive-metastore, but do not duplicate code unless necessary, do you suggest a directory for common? E.g., ``` hive-metastore/common hive-metastore/v2 hive-metastore/v3 hive-metastore/v4 ``` The idea has some appeal, but I didn't do this as I was trying to avoid too much disruption to the existing code base. It seems a lot more moving files around without substantial benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
