wypoon commented on code in PR #12681:
URL: https://github.com/apache/iceberg/pull/12681#discussion_r2023308361
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -445,7 +444,7 @@ public void testCreateTableCustomSortOrder() throws
Exception {
@Test
public void testDatabaseAndNamespaceWithLocation() throws Exception {
- Namespace namespace1 = Namespace.of("noLocation");
+ Namespace namespace1 = Namespace.of("nolocation");
Review Comment:
With `Namespace.of("noLocation")`, when `HiveCatalog::createNamespace` is
called, the metastore client calls `createDatabase` with a `Database`
containing name "noLocation" and locationUri ending with "noLocation.db", but
when the client calls `getDatabase`, it gets back a `Database` containing name
"nolocation" and locationUri ending with "nolocation.db". On disk, however, I
can see that a directory "noLocation.db" has been created in the warehouse
directory.
@pvary @deniskuzZ could you shed light on what changed in Hive 4 that causes
this behavior? Is it anything we need to do something about on the Iceberg side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
