wypoon commented on code in PR #12681:
URL: https://github.com/apache/iceberg/pull/12681#discussion_r2032146553
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java:
##########
@@ -303,10 +303,10 @@ public void testThriftExceptionConcurrentCommit() throws
TException, Interrupted
@Test
public void testInvalidObjectException() {
- TableIdentifier badTi = TableIdentifier.of(DB_NAME, "`tbl`");
+ TableIdentifier badTi = TableIdentifier.of(DB_NAME, "tábl");
Review Comment:
No, we do not. The purpose of the test is simply to test exception handling
when the table name is not accepted by Hive. For this purpose, any name not
accepted by Hive would do. Previously, a name containing the backtick character
('`') fit the bill, but now we need to use a different kind of name; that's all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
