wypoon commented on PR #12681: URL: https://github.com/apache/iceberg/pull/12681#issuecomment-2779908426
@pvary I have rebased on main. I see that this picked up https://github.com/apache/iceberg/commit/c661a71091e496393c743ddd879d9e1a0f2747b2 / https://github.com/apache/iceberg/pull/12637. In that change, a new test was added: `TestHiveCommitLocks::testMultipleAlterTableForNoLock`. This fails for Hive 3.1.3. I checked https://issues.apache.org/jira/browse/HIVE-26882 and see that it is fixed in 2.3.10 and 4.0.0-beta-1; it does not seem to be fixed in Hive 3 as there is no release after 3.1.3. Based on the date of the last commit in https://github.com/apache/hive/commits/rel/release-3.1.3/ and the date https://github.com/apache/hive/pull/3944 was merged, I conclude that HIVE-26882 is not available in 3.1.3. Based on my understanding, it is not safe to set `engine.hive.lock-enabled` to false if HIVE-26882 is not available in the HMS version. @lirui-apache can you confirm? I have disabled `TestHiveCommitLocks::testMultipleAlterTableForNoLock` for Hive 3 to avoid the failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
