RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2019429914
##########
core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java:
##########
@@ -152,9 +160,10 @@ public void testV2WriteWithInheritance() throws
IOException {
checkEntry(readManifest(manifest), SEQUENCE_NUMBER, SEQUENCE_NUMBER,
FileContent.DATA);
}
- @Test
- public void testV2WriteDelete() throws IOException {
- ManifestFile manifest = writeDeleteManifest(2);
+ @ParameterizedTest
+ @ValueSource(ints = {2, MAX_FORMAT_VERSION})
Review Comment:
I would probably use ALL_VERSIONS here too and just do an assume not 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
