RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2019465241
##########
core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java:
##########
@@ -213,27 +224,125 @@ public void testV2ManifestRewriteWithInheritance()
throws IOException {
checkRewrittenEntry(readManifest(manifest2), 0L, FileContent.DATA);
}
+ @Test
+ public void testV3Write() throws IOException {
+ ManifestFile manifest = writeManifest(3);
+ checkEntry(
+ readManifest(manifest),
+ ManifestWriter.UNASSIGNED_SEQ,
+ ManifestWriter.UNASSIGNED_SEQ,
+ FileContent.DATA,
+ FIRST_ROW_ID);
+ }
+
+ @Test
+ public void testV3WriteWithInheritance() throws IOException {
Review Comment:
These tests are pretty hard for me to follow. I probably just haven't been
in this code in a while but I can't tell what each one is trying to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
