deniskuzZ commented on code in PR #12681:
URL: https://github.com/apache/iceberg/pull/12681#discussion_r2023418469
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -445,7 +444,7 @@ public void testCreateTableCustomSortOrder() throws
Exception {
@Test
public void testDatabaseAndNamespaceWithLocation() throws Exception {
- Namespace namespace1 = Namespace.of("noLocation");
+ Namespace namespace1 = Namespace.of("nolocation");
Review Comment:
difference is probably because Hive doesn't normally use
`HiveCatalog#createNamespace`, only `HMS RestCatalog` does
````
database.setLocationUri(new Path(getExternalWarehouseLocation(),
namespace.level(0)).toString() + ".db");
````
HMS
````
private String dbDirFromDbName(Database db) throws MetaException {
return db.getName().toLowerCase() + DATABASE_WAREHOUSE_SUFFIX;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
