nastra commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2026825325
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -417,11 +426,9 @@ private static void
writeAddSnapshot(MetadataUpdate.AddSnapshot update, JsonGene
SnapshotParser.toJson(update.snapshot(), gen);
}
- // TODO - Reconcile the spec's set-based removal with the current class
implementation that only
- // handles one value.
- private static void writeRemoveSnapshots(MetadataUpdate.RemoveSnapshot
update, JsonGenerator gen)
+ private static void writeRemoveSnapshot(MetadataUpdate.RemoveSnapshots
update, JsonGenerator gen)
Review Comment:
I would keep the name in its plural form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
