nastra commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2026821208


##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -328,6 +328,11 @@ public void applyTo(TableMetadata.Builder metadataBuilder) 
{
     }
   }
 
+  /**
+   * @deprecated since 1.8.1, will be removed in 2.0.0; Use {@link 
MetadataUpdate.RemoveSnapshots}

Review Comment:
   ```suggestion
      * @deprecated since 1.10.0, will be removed in 1.11.0; Use {@link 
MetadataUpdate.RemoveSnapshots}
   ```
   In case this makes it into 1.9.0, the javadoc should be updated to 1.9.0 / 
removal = 1.10.0



##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -328,6 +328,11 @@ public void applyTo(TableMetadata.Builder metadataBuilder) 
{
     }
   }
 
+  /**
+   * @deprecated since 1.8.1, will be removed in 2.0.0; Use {@link 
MetadataUpdate.RemoveSnapshots}
+   *     instead.
+   */
+  @Deprecated()

Review Comment:
   ```suggestion
     @Deprecated
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to