amogh-jahagirdar commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2027096293
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -415,9 +416,9 @@ public void testAddSnapshotFromJson() throws IOException {
assertEquals(action, expected, MetadataUpdateParser.fromJson(json));
}
- /** RemoveSnapshots * */
+ /** RemoveSnapshot * */
@Test
- public void testRemoveSnapshotsFromJson() {
+ public void testRemoveSnapshotFromJson() {
Review Comment:
Nit: Normally I'd say we shouldn't really make this change to the different
test names and just prefer to keep it as is. I understand the intent so it's OK
but the assertions in this test will anyways change in the future when
RemoveSnapshot is removed. It'd make more sense to change it at that point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
