ricardopereira33 commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2024439959
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -150,7 +148,7 @@ private MetadataUpdateParser() {}
.put(MetadataUpdate.SetPartitionStatistics.class,
SET_PARTITION_STATISTICS)
.put(MetadataUpdate.RemovePartitionStatistics.class,
REMOVE_PARTITION_STATISTICS)
.put(MetadataUpdate.AddSnapshot.class, ADD_SNAPSHOT)
- .put(MetadataUpdate.RemoveSnapshot.class, REMOVE_SNAPSHOTS)
+ .put(MetadataUpdate.RemoveSnapshots.class, REMOVE_SNAPSHOTS)
Review Comment:
> Reuse the same keyword, and add a custom condition to distinguish
RemoveSnapshot and RemoveSnapshots
@amogh-jahagirdar yes, that was exactly what I meant for the first option 😆
I will prepare the changes today, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
