nastra commented on code in PR #12670: URL: https://github.com/apache/iceberg/pull/12670#discussion_r2026842088
########## core/src/main/java/org/apache/iceberg/TableMetadata.java: ########## @@ -1436,12 +1436,14 @@ public Builder removeSnapshots(Collection<Long> idsToRemove) { private Builder rewriteSnapshotsInternal(Collection<Long> idsToRemove, boolean suppress) { List<Snapshot> retainedSnapshots = Lists.newArrayListWithExpectedSize(snapshots.size() - idsToRemove.size()); + Set<Long> removedSnapshotIds = Sets.newHashSet(); Review Comment: ```suggestion Set<Long> snapshotIdsToRemove = Sets.newHashSet(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org