nastra commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2026824248
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -229,7 +230,15 @@ public static void toJson(MetadataUpdate metadataUpdate,
JsonGenerator generator
writeAddSnapshot((MetadataUpdate.AddSnapshot) metadataUpdate,
generator);
break;
case REMOVE_SNAPSHOTS:
- writeRemoveSnapshots((MetadataUpdate.RemoveSnapshot) metadataUpdate,
generator);
+ // TODO: Remove condition once RemoveSnapshot is deprecated and removed
Review Comment:
I think we can remove the TODO here and further above, because once
`RemoveSnapshot` is actually removed, the code won't compile and this code will
need to be updated anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
