nastra commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2021086192
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -419,18 +420,18 @@ public void testAddSnapshotFromJson() throws IOException {
@Test
public void testRemoveSnapshotsFromJson() {
String action = MetadataUpdateParser.REMOVE_SNAPSHOTS;
- long snapshotId = 2L;
- String json = String.format("{\"action\":\"%s\",\"snapshot-ids\":[2]}",
action);
- MetadataUpdate expected = new MetadataUpdate.RemoveSnapshot(snapshotId);
+ Set<Long> snapshotIds = Sets.newHashSet(2L, 3L);
Review Comment:
existing tests should work as before and should stay untouched (for backward
compability). Then you'd go ahead and add a few tests that use the new API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
