amogh-jahagirdar commented on code in PR #12670:
URL: https://github.com/apache/iceberg/pull/12670#discussion_r2019058000
##########
.palantir/revapi.yml:
##########
@@ -1178,6 +1178,11 @@ acceptedBreaks:
new: "class org.apache.iceberg.Metrics"
justification: "Java serialization across versions is not guaranteed"
org.apache.iceberg:iceberg-core:
+ - code: "java.class.removed"
+ old: "class org.apache.iceberg.MetadataUpdate.RemoveSnapshot"
+ justification: "Changing the RemoveSnapshot class to receive a list of
snapshots\
+ \ IDs instead of a single snapshot ID. This will make the remove
snapshots\
+ \ more efficient."
- code: "java.method.removed"
Review Comment:
I was wrong here, the protocol is already actually a [`RemoveSnapshots<list
snapshots>`](https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L2833).
This `RemoveSnapshot` is really more of how it's mapped internally ,and is
unfortunately exposed to the public. I still think we'd need to keep this for
library compatibility, but make the implementation less restrictive insetead of
only allowing 1 snapshot in the `RemoveSnapshots` list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
