RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2019427982
##########
core/src/test/java/org/apache/iceberg/TestManifestListVersions.java:
##########
@@ -300,17 +433,34 @@ public void testManifestsPartitionSummary() throws
IOException {
}
private InputFile writeManifestList(ManifestFile manifest, int
formatVersion) throws IOException {
- OutputFile manifestList = new InMemoryOutputFile();
- try (FileAppender<ManifestFile> writer =
+ return writeManifestList(formatVersion, WRITER_FIRST_ROW_ID, manifest);
+ }
+
+ private InputFile writeManifestList(int formatVersion, long nextRowId,
ManifestFile... manifests)
+ throws IOException {
+ OutputFile outputFile = new InMemoryOutputFile();
+ ManifestListWriter writer =
ManifestLists.write(
formatVersion,
- manifestList,
+ outputFile,
SNAPSHOT_ID,
SNAPSHOT_ID - 1,
- formatVersion > 1 ? SEQ_NUM : 0)) {
- writer.add(manifest);
+ formatVersion > 1 ? SEQ_NUM : 0,
+ WRITER_FIRST_ROW_ID);
+
+ try (writer) {
+ for (ManifestFile manifest : manifests) {
+ writer.add(manifest);
+ }
}
- return manifestList.toInputFile();
+
+ if (formatVersion >= 3) {
Review Comment:
nit: 3 => ROW_FORMAT version constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
