rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2019421684
########## core/src/main/java/org/apache/iceberg/InheritableMetadataFactory.java: ########## @@ -50,13 +52,19 @@ static class BaseInheritableMetadata implements InheritableMetadata { private final long snapshotId; private final long sequenceNumber; private final String manifestLocation; + private Long nextRowId; Review Comment: No, we create a separate `InheritableMetadata` for each manifest reader and the readers make no guarantees about thread safety. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org