hsiang-c commented on code in PR #12511:
URL: https://github.com/apache/iceberg/pull/12511#discussion_r1996433987
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcViewCatalog.java:
##########
@@ -138,4 +142,50 @@ public void testCommitExceptionWithMessage() {
.hasMessageStartingWith("View already exists: " + identifier);
}
}
+
+ @Test
+ public void dropViewShouldNotDropMetadataFileIfGcNotEnabled() throws
IOException {
Review Comment:
@ebyhr
I gave it a try and I think the file existence check doesn't work for
`InMemoryCatalog` and therefore `TestInMemoryViewCatalog` fails. `
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcViewCatalog.java:
##########
@@ -138,4 +142,50 @@ public void testCommitExceptionWithMessage() {
.hasMessageStartingWith("View already exists: " + identifier);
}
}
+
+ @Test
+ public void dropViewShouldNotDropMetadataFileIfGcNotEnabled() throws
IOException {
Review Comment:
@ebyhr
I gave it a try and I think the file existence check doesn't work for
`InMemoryCatalog` and therefore `TestInMemoryViewCatalog` fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
