hsiang-c commented on code in PR #12511:
URL: https://github.com/apache/iceberg/pull/12511#discussion_r1996443096
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -612,6 +613,14 @@ public boolean dropView(TableIdentifier identifier) {
throw new UnsupportedOperationException(VIEW_WARNING_LOG_MESSAGE);
}
+ JdbcViewOperations ops = (JdbcViewOperations) newViewOps(identifier);
+ ViewMetadata lastViewMetadata = null;
+ try {
+ lastViewMetadata = ops.current();
+ } catch (NotFoundException e) {
Review Comment:
Good catch, thanks.
`BaseViewOperations`'s `refresh()` method throws `NoSuchViewException`
I also applied the fix to `dropTable` b/c `BaseMetastoreTableOperations`'s
`refresh()` method throws `NoSuchTableException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]