hsiang-c commented on code in PR #12511: URL: https://github.com/apache/iceberg/pull/12511#discussion_r2001677003
########## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ########## @@ -612,6 +613,14 @@ public boolean dropView(TableIdentifier identifier) { throw new UnsupportedOperationException(VIEW_WARNING_LOG_MESSAGE); } + JdbcViewOperations ops = (JdbcViewOperations) newViewOps(identifier); Review Comment: @nastra The `io()` method is defined in `BaseViewOperations` instead of `ViewOperations` and I need to call `ops.io()` to drop view's metadata. Perhaps we could define `FileIO io()` in the `ViewOperations` interface, just like `TableOperations`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org