amogh-jahagirdar commented on code in PR #12511:
URL: https://github.com/apache/iceberg/pull/12511#discussion_r2002321359
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -612,6 +613,14 @@ public boolean dropView(TableIdentifier identifier) {
throw new UnsupportedOperationException(VIEW_WARNING_LOG_MESSAGE);
}
+ JdbcViewOperations ops = (JdbcViewOperations) newViewOps(identifier);
Review Comment:
I think I'd prefer to leave it as is at least for now. IMO the issue with
upleveling `FileIO io()` to ViewOperations is that implementations like
RESTViewOperations don't really need a FileIO instance to be able to write out
or read metadata (in the REST case it's all over the protocol). So the concept
doesn't really apply to every instance of `ViewOperations`.
Maybe there's a mixin or something to make this cleaner, but I wouldn't
introduce it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
