akhilputhiry commented on code in PR #12406:
URL: https://github.com/apache/iceberg/pull/12406#discussion_r1991755395
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -55,7 +56,22 @@ public class RESTCatalog
public RESTCatalog() {
this(
SessionCatalog.SessionContext.createEmpty(),
- config ->
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI)).build());
+ config -> {
+ HTTPClient.Builder builder =
+
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI));
+
+ boolean proxyEnabled =
+ PropertyUtil.propertyAsBoolean(
+ config, CatalogProperties.PROXY_ENABLED,
CatalogProperties.PROXY_ENABLED_DEFAULT);
+
+ if (proxyEnabled) {
+ builder.withProxy(
+ config.get(CatalogProperties.PROXY_HOSTNAME),
+ Integer.parseInt(config.get(CatalogProperties.PROXY_PORT)));
+ }
+
+ return builder.build();
Review Comment:
Thanks @adutra I have made changes as per your suggestion.
Can you point me to some committers who will be able to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
