akhilputhiry commented on PR #12406: URL: https://github.com/apache/iceberg/pull/12406#issuecomment-2689600902
> Can you confirm that adding ProxySupport on top of the existing code will work, e.g. if withProxy is used? > Yes it works, I had tested with `org.apache.iceberg.rest.HTTPClient.Builder#withProxy` > Secondly, the introduction of proxy support in HTTPClient has me wondering for a while how this is supposed to work in the case where the IDP is external. > Thinking of making it explicit to RESTCatalog by moving to `org.apache.iceberg.rest.RESTCatalog.java` and controlling via properties > This may not be desirable in all cases. I would like to make it possible to select different proxy configurations depending on the request URL. Do you think that would be possible with ProxySupport? > For IDP scenario, similar approach of having proxy setting and using it via builder should address the problem I believe Updated the PR with new approach. Let me know your thoughts. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
