adutra commented on PR #12406: URL: https://github.com/apache/iceberg/pull/12406#issuecomment-2688884965
Hi @akhilputhiry while I understand the problem I think there are a few concerns with this PR: First off, there is already some proxy support in `HTTPClient`: 1. `org.apache.iceberg.rest.HTTPClient.Builder#withProxy` 2. `org.apache.iceberg.rest.HTTPClient.Builder#withProxyCredentialsProvider` Can you confirm that adding `ProxySupport` on top of the existing code will work, e.g. if `withProxy` is used? Or are these two things mutually exclusive? I also think that you should pass the `ProxySelector` via the builder, just like the methods above. Secondly, the introduction of proxy support in `HTTPClient` has me wondering for a while how this is supposed to work in the case where the IDP is external. Right now, my understanding is that if a proxy is defined, it will be used for _all_ requests, both to the catalog server and the IDP. This may not be desirable in all cases. I would like to make it possible to select different proxy configurations depending on the request URL. Do you think that would be possible with `ProxySupport`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
