nastra commented on code in PR #12406: URL: https://github.com/apache/iceberg/pull/12406#discussion_r1993659625
########## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ########## @@ -32,6 +32,17 @@ private CatalogProperties() {} public static final String VIEW_DEFAULT_PREFIX = "view-default."; public static final String METRICS_REPORTER_IMPL = "metrics-reporter-impl"; + /** http proxy configuration for rest catalog */ + public static final String PROXY_HOSTNAME = "proxy.hostname"; + + public static final String PROXY_HOSTNAME_DEFAULT = ""; Review Comment: I don't think we need to define any of the defaults here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org