nastra commented on code in PR #12406:
URL: https://github.com/apache/iceberg/pull/12406#discussion_r1993676584
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -55,7 +59,50 @@ public class RESTCatalog
public RESTCatalog() {
this(
SessionCatalog.SessionContext.createEmpty(),
- config ->
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI)).build());
+ config -> {
+ HTTPClient.Builder builder =
+
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI));
+
+ String proxyHostname =
+ PropertyUtil.propertyAsString(
+ config,
+ CatalogProperties.PROXY_HOSTNAME,
+ CatalogProperties.PROXY_HOSTNAME_DEFAULT);
+
+ int proxyPort =
+ PropertyUtil.propertyAsInt(
+ config, CatalogProperties.PROXY_PORT,
CatalogProperties.PROXY_PORT_DEFAULT);
+
+ if (!proxyHostname.isEmpty()) {
+
+ builder.withProxy(proxyHostname, proxyPort);
+
+ String proxyUsername =
+ PropertyUtil.propertyAsString(
+ config,
+ CatalogProperties.PROXY_USERNAME,
+ CatalogProperties.PROXY_USERNAME_DEFAULT);
+
+ String proxyPassword =
+ PropertyUtil.propertyAsString(
+ config,
+ CatalogProperties.PROXY_PASSWORD,
+ CatalogProperties.PROXY_PASSWORD_DEFAULT);
Review Comment:
same as for the others, the default should be `null` instead of specifying
an empty string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
