nastra commented on code in PR #12406:
URL: https://github.com/apache/iceberg/pull/12406#discussion_r1993674934
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -55,7 +59,50 @@ public class RESTCatalog
public RESTCatalog() {
this(
SessionCatalog.SessionContext.createEmpty(),
- config ->
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI)).build());
+ config -> {
+ HTTPClient.Builder builder =
+
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI));
+
+ String proxyHostname =
+ PropertyUtil.propertyAsString(
+ config,
+ CatalogProperties.PROXY_HOSTNAME,
+ CatalogProperties.PROXY_HOSTNAME_DEFAULT);
+
+ int proxyPort =
+ PropertyUtil.propertyAsInt(
+ config, CatalogProperties.PROXY_PORT,
CatalogProperties.PROXY_PORT_DEFAULT);
Review Comment:
I'm not sure we should be defaulting to a proxy port. I'd rather mandate
that the port always needs to be provided, hence this would be `Integer
proxyPort = PropertyUtil.propertyAsNullableInt(..)`. And then later you would
null check both the hostname/port to determine whether
`builder.withProxy(proxyHostname, proxyPort)` can be called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
