aihuaxu commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1929307357
##########
api/src/test/java/org/apache/iceberg/types/TestTypeUtil.java:
##########
@@ -24,38 +24,43 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import java.util.Set;
+import java.util.stream.Stream;
import org.apache.iceberg.Schema;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.relocated.com.google.common.collect.Sets;
-import org.apache.iceberg.types.Types.IntegerType;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
public class TestTypeUtil {
- @Test
- public void testReassignIdsDuplicateColumns() {
+ private static Stream<Arguments> testTypes() {
+ return Stream.of(Arguments.of(Types.IntegerType.get()),
Arguments.of(Types.VariantType.get()));
+ }
+
+ @ParameterizedTest
+ @MethodSource("testTypes")
+ public void testReassignIdsDuplicateColumns(Type testType) {
Review Comment:
I was trying to add the coverage for Variant changes for the visitors such
as ReassignIds or PruneColumns with the existing tests. I guess what you
suggest with some additional tests should be able to provide coverage for them.
Let me look into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
