aihuaxu commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1929433492
##########
core/src/test/java/org/apache/iceberg/avro/TestBuildAvroProjection.java:
##########
@@ -401,4 +402,32 @@ public void projectMapWithLessFieldInValueSchema() {
.as("Unexpected value ID discovered on the projected map schema")
.isEqualTo(1);
}
+
+ @Test
+ public void projectVariantSchemaUnchanged() {
+ final Type icebergType = Types.VariantType.get();
+
+ final org.apache.avro.Schema expected =
+ SchemaBuilder.record("variant")
+ .namespace("unit.test")
+ .fields()
+ .name("metadata")
Review Comment:
You are right. variant `value` and `metadata` should not be assigned IDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
