rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1927935200
##########
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##########
@@ -49,6 +49,15 @@ abstract class TypeToSchema extends
TypeUtil.SchemaVisitor<Schema> {
private static final Schema UUID_SCHEMA =
LogicalTypes.uuid().addToSchema(Schema.createFixed("uuid_fixed", null,
null, 16));
private static final Schema BINARY_SCHEMA = Schema.create(Schema.Type.BYTES);
+ private static final Schema VARIANT_SCHEMA =
Review Comment:
I think this will break when there are multiple variant columns because Avro
requires each record to have a unique name. This is why record names are
generated from field IDs. Can you create a test case to validate this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
