aihuaxu commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1935955729
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -61,6 +61,14 @@ private Types() {}
private static final Pattern DECIMAL =
Pattern.compile("decimal\\(\\s*(\\d+)\\s*,\\s*(\\d+)\\s*\\)");
+ public static Type typeFromTypeString(String typeString) {
Review Comment:
Actually it will introduces incompatibility since the return type changes.
Let me know if that works or maybe we can introduce a new one as I did
initially.
> old: method org.apache.iceberg.types.Type.PrimitiveType
org.apache.iceberg.types.Types::fromPrimitiveString(java.lang.String)
> new: method org.apache.iceberg.types.Type
org.apache.iceberg.types.Types::fromPrimitiveString(java.lang.String)
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
