rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1927926739
##########
api/src/test/java/org/apache/iceberg/types/TestTypeUtil.java:
##########
@@ -85,33 +89,33 @@ public void testAssignIncreasingFreshIdWithIdentifier() {
.isEqualTo(expectedSchema.identifierFieldIds());
}
- @Test
- public void testAssignIncreasingFreshIdNewIdentifier() {
+ @ParameterizedTest
+ @MethodSource("testTypes")
+ public void testAssignIncreasingFreshIdNewIdentifier(Type testType) {
Review Comment:
@aihuaxu, it looks like I'd be pasting this message a lot. Please roll back
all changes to this test suite and add new behavior tests to exercise the
relevant behavior for variants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
