rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1927930058
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -61,6 +61,14 @@ private Types() {}
private static final Pattern DECIMAL =
Pattern.compile("decimal\\(\\s*(\\d+)\\s*,\\s*(\\d+)\\s*\\)");
+ public static Type typeFromTypeString(String typeString) {
Review Comment:
I also think that if we want to have an additional method to avoid confusion
(i.e. "I don't want to `fromPrimitiveString` that because I need support for
variant") then we can add a synonym. In that case, I think there's probably a
better name, like `fromString`. That's not great because it implies that it
would support structs, maps, and lists, but so does `typeFromTypeString` so
it's at least more direct. Unfortunately, we don't have a word in Iceberg that
means a type that is expressed in a single string (vs a JSON-defined type).
I would probably just leave this as `fromPrimitiveString` and not worry
about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
