rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917263968
##########
api/src/test/java/org/apache/iceberg/util/RandomUtil.java:
##########
@@ -237,7 +237,7 @@ private static BigInteger randomUnscaled(int precision,
Random random) {
}
public static List<Object> generateList(
- Random random, Types.ListType list, Supplier<Object> elementResult) {
Review Comment:
How about `elementSupplier` instead? I think that's more accurate than
`elements` for two reasons. First, the argument is not an element, it is a
function that produces an element. Second, there is only one supplier so the
name shouldn't be plural.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
