rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917285311
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -397,7 +404,7 @@ public ParquetValueReader<?> primitive(
case INT96:
// Impala & Spark used to write timestamps as INT96 without a
logical type. For backwards
// compatibility we try to read INT96 as timestamps.
- return new TimestampInt96Reader(desc);
+ return int96Reader(desc);
Review Comment:
Can't this call `timestampReader(desc, NANOS, ((TimestampType)
primitive).isAdjustedToUTC())` instead? The primitive type is available from
`desc` so that method can check and we don't need to have a factory method for
INT96.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
