rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917264392
##########
api/src/test/java/org/apache/iceberg/util/RandomUtil.java:
##########
@@ -246,15 +246,15 @@ public static List<Object> generateList(
if (list.isElementOptional() && random.nextInt(20) == 1) {
result.add(null);
} else {
- result.add(elementResult.get());
+ result.add(elements.get());
}
}
return result;
}
public static Map<Object, Object> generateMap(
- Random random, Types.MapType map, Supplier<Object> keyResult,
Supplier<Object> valueResult) {
+ Random random, Types.MapType map, Supplier<Object> keyResult,
Supplier<Object> values) {
Review Comment:
Similarly, I think `valueSupplier` is a better name. This also doesn't
address the problem for `keyResult`, which should also be `keySupplier`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
