ajantha-bhat commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1911784070
##########
.palantir/revapi.yml:
##########
@@ -1171,6 +1171,28 @@ acceptedBreaks:
\ java.util.function.Function<T, java.lang.Long>,
org.apache.iceberg.io.CloseableIterable<java.lang.Long>,\
\ java.util.function.Consumer<T>)"
justification: "Removing deprecated code"
+ org.apache.iceberg:iceberg-parquet:
+ - code: "java.method.abstractMethodAdded"
+ new: "method
org.apache.iceberg.parquet.ParquetValueReaders.PrimitiveReader<?>\
+ \
org.apache.iceberg.data.parquet.BaseParquetReaders<T>::fixedReader(org.apache.parquet.column.ColumnDescriptor)"
+ justification: "{Refactor Parquet reader and writer}"
+ - code: "java.method.abstractMethodAdded"
+ new: "method
org.apache.iceberg.parquet.ParquetValueReaders.PrimitiveReader<?>\
+ \
org.apache.iceberg.data.parquet.BaseParquetReaders<T>::int96Reader(org.apache.parquet.column.ColumnDescriptor)"
+ justification: "{Refactor Parquet reader and writer}"
+ - code: "java.method.abstractMethodAdded"
+ new: "method
org.apache.iceberg.parquet.ParquetValueWriters.PrimitiveWriter<?>\
+ \
org.apache.iceberg.data.parquet.BaseParquetWriter<T>::fixedWriter(org.apache.parquet.column.ColumnDescriptor)"
+ justification: "{Refactor Parquet reader and writer}"
+ - code: "java.method.abstractMethodAdded"
+ new: "method
org.apache.parquet.schema.LogicalTypeAnnotation.LogicalTypeAnnotationVisitor<org.apache.iceberg.parquet.ParquetValueReader<?>>\
+ \
org.apache.iceberg.data.parquet.BaseParquetReaders<T>::logicalTypeReaderVisitor(org.apache.parquet.column.ColumnDescriptor,\
+ \ org.apache.iceberg.types.Type.PrimitiveType,
org.apache.parquet.schema.PrimitiveType)"
+ justification: "{Refactor Parquet reader and writer}"
+ - code: "java.method.abstractMethodAdded"
Review Comment:
Oh, I think what you mean is don't add it as abstract. Add it as methods
with default implementation. I got it. I will update it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
