jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1810998054
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -498,6 +506,8 @@ public S3FileIOProperties() {
this.s3RetryNumRetries = S3_RETRY_NUM_RETRIES_DEFAULT;
this.s3RetryMinWaitMs = S3_RETRY_MIN_WAIT_MS_DEFAULT;
this.s3RetryMaxWaitMs = S3_RETRY_MAX_WAIT_MS_DEFAULT;
+ this.isTreatS3DirectoryBucketListPrefixAsDirectoryEnabled =
Review Comment:
the name of the variable and the constant does not match, can we just call
this `s3DirectoryBucketListPrefixAsDirectory`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
