stubz151 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1810971888
##########
aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java:
##########
@@ -127,6 +129,21 @@ public static void cleanS3Bucket(S3Client s3, String
bucketName, String prefix)
}
}
+ /**
+ * Method used to clean up a S3 directory bucket which doesn't care about
versions
+ *
+ * @param s3FileIO an instance of s3FileIO to be used to list/delete objects
+ * @param bucketName name of the bucket
+ * @param prefix the path prefix we want to remove
+ */
+ public static void cleanS3DirectoryBucket(S3FileIO s3FileIO, String prefix,
String bucketName) {
Review Comment:
So it was like like that in the first revision, changed based on
recommendations from the prior reviews.
I guess if S3FileIO.deleteFiles does go wrong it would be picked up by the
tests doing the exact same thing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
